Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StyleCop] Fix all the warnings on Bot.Builder.Tests #1510

Merged
merged 3 commits into from
Mar 21, 2019
Merged

[StyleCop] Fix all the warnings on Bot.Builder.Tests #1510

merged 3 commits into from
Mar 21, 2019

Conversation

ceciliaavila
Copy link
Collaborator

  • Add/remove spacing
  • Add element's documentation
  • Fix upper/lowercase letters
  • Remove prefix calls with base
  • Fix constructors initializer
  • Remove unused variables
  • Rename variable's name

@ceciliaavila ceciliaavila mentioned this pull request Mar 18, 2019
Closed
@coveralls
Copy link
Collaborator

coveralls commented Mar 19, 2019 •
edited

Pull Request Test Coverage Report for Build 51935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 84 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 75.588%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/WaterfallStepContext.cs 8 65.22%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogContext.cs 27 72.73%
/libraries/Microsoft.Bot.Builder/Adapters/TestAdapter.cs 49 81.29%
Totals Coverage Status
Change from base Build 51599: 0.0%
Covered Lines: 4304
Relevant Lines: 5694
💛 - Coveralls

@ParadoxARG ParadoxARG marked this pull request as ready for review March 19, 2019 21:02
@munozemilio munozemilio merged commit a490f79 into master Mar 21, 2019
@munozemilio munozemilio deleted the fix/stylecop/Tests branch March 21, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasper-az gasper-az gasper-az left review comments

@munozemilio munozemilio munozemilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ceciliaavila @coveralls @munozemilio @gasper-az @Maihav @Bill7zz