Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update webapi to core bot #1533

Merged
merged 2 commits into from
Mar 22, 2019
Merged

update webapi to core bot #1533

merged 2 commits into from
Mar 22, 2019

Conversation

johnataylor
Copy link
Member

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Mar 21, 2019 •
edited

Pull Request Test Coverage Report for Build 51938

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 75.588%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder/Adapters/TestAdapter.cs 49 81.29%
Totals Coverage Status
Change from base Build 51925: 0.0%
Covered Lines: 4304
Relevant Lines: 5694
💛 - Coveralls

Kaiqb
Kaiqb suggested changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@Kaiqb Kaiqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • When the app loads, the browser shows "HTTP Error 403.14 - Forbidden" message. Even though the Emulator connects and works successfully.
  • The WebApiConfig.cs needs copyright header.

@johnataylor johnataylor merged commit 61897e2 into master Mar 22, 2019
@johnataylor johnataylor deleted the johtaylo/testbot-webapi-update branch March 22, 2019 17:29
@ParadoxARG ParadoxARG mentioned this pull request Mar 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaiqb Kaiqb Kaiqb approved these changes

@munozemilio munozemilio Awaiting requested review from munozemilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnataylor @coveralls @Kaiqb