Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StyleCop] Update XML documentation suppress rule #1543

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

denscollo
Copy link
Contributor

Remove the Property used to suppress the rule SA0001. This was applied to the projects that didn't support ruleset files, but now all the projects use an unique ruleset file.

image

Also, the rules SA0001 and SA1652 about the XML documentation were moved into the ruleset file.
image

Finally, we updated the StyleCop version to 1.1.0-beta008, to properly support the C# version used by the projects of the solution.
image

Currently, all the projects are configured to set the latest major version of C#. and uses some features of c# 7.0 like:

  • throw expressions
    This feature enables using throw expressions in initialization expressions:
    image

  • is expression
    The is pattern expression extends the familiar is operator to query an object beyond its type.
    image

  • tuples syntax
    image

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 52032

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.588%

Totals Coverage Status
Change from base Build 52017: 0.0%
Covered Lines: 4304
Relevant Lines: 5694

💛 - Coveralls

@cleemullins cleemullins merged commit d6463c2 into master Mar 26, 2019
@cleemullins cleemullins deleted the fix/stylecop/update-no-warn-rule branch March 26, 2019 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants