Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line channel updates #1547

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Line channel updates #1547

merged 2 commits into from
Mar 27, 2019

Conversation

EricDahlvang
Copy link
Member

Fixes microsoft/botframework-sdk#5316
and
microsoft/botframework-sdk#5313

OAuthPrompt (tested and works)

Dialogs Channel: added LIne
- SupportsSuggestedActions: 13
- SupportsCardActions: 99

Channel Constant: added Line

Add ChoicesChannelTests

@coveralls
Copy link
Collaborator

coveralls commented Mar 23, 2019

Pull Request Test Coverage Report for Build 52350

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.5%) to 76.0%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.ApplicationInsights/BotTelemetryClient.cs 1 98.85%
/libraries/Microsoft.Bot.Builder.TemplateManager/DictionaryRenderer.cs 3 82.35%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisPredictionOptions.cs 6 33.33%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogContext.cs 9 76.15%
/libraries/Microsoft.Bot.Builder.TemplateManager/TemplateManager.cs 10 79.25%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisRecognizer.cs 27 76.19%
Totals Coverage Status
Change from base Build 52064: 0.5%
Covered Lines: 4332
Relevant Lines: 5700

💛 - Coveralls

@cleemullins cleemullins merged commit e177f5e into master Mar 27, 2019
@cleemullins cleemullins deleted the eric/lineChannelUpdates branch March 27, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants