Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace dialogs calls end dialog #1555

Merged
merged 1 commit into from
Mar 26, 2019
Merged

replace dialogs calls end dialog #1555

merged 1 commit into from
Mar 26, 2019

Conversation

johnataylor
Copy link
Member

fixes #1366

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 52225

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 75.784%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/DialogContext.cs 6 77.97%
Totals Coverage Status
Change from base Build 52177: 0.2%
Covered Lines: 4325
Relevant Lines: 5707
💛 - Coveralls

cleemullins
cleemullins approved these changes Mar 26, 2019
View reviewed changes
libraries/Microsoft.Bot.Builder.Dialogs/DialogExtensions.cs
{
public static class DialogExtensions
{
public static async Task RunAsync(this Dialog dialog, ITurnContext turnContext, IStatePropertyAccessor<DialogState> accessor, CancellationToken cancellationToken)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should cancellation token be optional? Defaulting it seems reasonable.

@cleemullins
Copy link
Contributor

@johnataylor - Approved, but not merged. I think that parameter should be optional, but will leave it to your discretion.

Is there a parallel JS PR to accompany?

@johnataylor
Copy link
Member Author

Steve is going to look at the JS

@johnataylor johnataylor merged commit 52513fb into master Mar 26, 2019
@johnataylor johnataylor deleted the johtaylo/replace-should-enddialog branch March 26, 2019 15:47
@ryanisgrig ryanisgrig mentioned this pull request Apr 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReplaceDialogAsync does not formally end active dialog
3 participants
@johnataylor @coveralls @cleemullins