Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share HttpClient to OIDC metadata document retriever #1625

Merged

Conversation

drub0y
Copy link
Contributor

@drub0y drub0y commented Apr 4, 2019

The HttpClient was not being shared with the ConfigurationManager<OpenIdConnectConfiguration>. Needed to pass the instance into the constructor overload so that it is used by the OpenIdConnectConfiguration when fetching the document.

Fixes #1595.

The `HttpClient` was not being shared with the `ConfigurationManager<OpenIdConnectConfiguration>`. Needed to pass the instance into the constructor overload so that it is used by the `OpenIdConnectConfiguration` when fetching the document.

Fixes #1595.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 53306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.121%

Totals Coverage Status
Change from base Build 53133: 0.0%
Covered Lines: 4361
Relevant Lines: 5729

💛 - Coveralls

@cleemullins
Copy link
Contributor

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll

@cleemullins
Copy link
Contributor

The rumor on the street (from Dana) is that even with this change the problem is still present. He's diving deeper into the issue now that he's got a proxy environment setup.

@dmvtech
Copy link
Collaborator

dmvtech commented Apr 9, 2019

@cleemullins It was user (my) error. All looks good. No errors implimenting @drub0y's branch and I can see the requests going through the proxy when implemented.

@cleemullins cleemullins merged commit d66e96a into master Apr 9, 2019
@cleemullins cleemullins deleted the drmarsh/share-httpclient-with-oidc-config-retriever branch April 9, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants