Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Johtaylo/issue1257 #1651

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Johtaylo/issue1257 #1651

merged 2 commits into from
Apr 11, 2019

Conversation

johnataylor
Copy link
Member

add NumberOfAttempts to PromptOptions
fixes microsoft/BotBuilder-Samples#1257

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 54024

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 76.186%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/Prompt.cs 4 82.0%
Totals Coverage Status
Change from base Build 53863: 0.03%
Covered Lines: 4402
Relevant Lines: 5778

💛 - Coveralls

@cleemullins
Copy link
Contributor

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll

@johnataylor johnataylor merged commit 8699569 into master Apr 11, 2019
@johnataylor johnataylor deleted the johtaylo/issue1257 branch April 11, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 April 15, 2019 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Know the number of attempts inside a validation
3 participants