Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring #1790

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Small refactoring #1790

merged 1 commit into from
Jun 6, 2019

Conversation

tony-xia
Copy link
Contributor

No description provided.

@cleemullins cleemullins added the blocked Current progress is blocked on something else. label Apr 25, 2019
@cleemullins cleemullins self-assigned this Apr 25, 2019
@cleemullins
Copy link
Contributor

@tony-xia

This is interesting. Could you:

  1. File an issue that describes the bug you're fixing.
  2. In the fix, we need a test (or 2) that fails before the fix and passes after.

Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While your code is indeed cleaner, I don't want to take it quite yet.

Once we get into 4.5, in the next week, we can re-evaluate.

As this is a fairly straightfoward refactor, it seems simple enough...

@cleemullins cleemullins added the 4.5 4.5 release label Apr 25, 2019
@tony-xia
Copy link
Contributor Author

Thanks @cleemullins . I am not sure whether I can find one test (or 2) that fails before the fix and passes after, because it's a code refactoring which keeps the same input, output and logic.

@cleemullins
Copy link
Contributor

I pushed this code to a branch and ran our CI system against it. That's found here:
#2023

Based on that, I'm merging this in.

@cleemullins cleemullins merged commit a028e3e into microsoft:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5 4.5 release blocked Current progress is blocked on something else.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants