Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issues form testing with Teams #1821

Merged
merged 1 commit into from
Apr 28, 2019
Merged

fixed issues form testing with Teams #1821

merged 1 commit into from
Apr 28, 2019

Conversation

johnataylor
Copy link
Member

  • add trim to text in message for inspect command processing

@fuselabs
Copy link
Collaborator 

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll

sgellock
sgellock reviewed Apr 28, 2019
View reviewed changes
Copy link
Member

@sgellock sgellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a C# guy, but this looks good Johnny

@cleemullins cleemullins merged commit adf6f92 into master Apr 28, 2019
@cleemullins cleemullins deleted the johtaylo/sidecarissues branch April 28, 2019 17:44
@cleemullins
Copy link
Contributor

Cherrypicked this over to the 4.4 branch, and all looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgellock sgellock sgellock left review comments

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johnataylor @fuselabs @cleemullins @sgellock