Take magic code detection out of OAuth BeginDialog

[mdrichardson]

Fixes #1596

Also related: https://stackoverflow.com/questions/55970661/ms-bot-framework-doesnt-remember-authentication/55975228#55975228 - this seems like a pretty easy issue to run into.

Issue Summary

OAuthPrompt has to be called to for certain messages. If that message contains a string that has a 6-digit number, OAuthPrompt used that number as the magic code, which was invalid, so it re-prompted for Login. The JS SDK doesn't have this issue because it doesn't check for the magic code in beginDialog()
.

Changes

• Removes attempt to detect magic code in BeginDialogAsync()
• Removes some other checks in GetUserTokenAsync() that are unnecessary because of the above change that are handled elsewhere

Important Notes

• I couldn't really get the Auth Sample (18) on master to work well with or without this change. The samples-work-in-progress sample works fine now.
• Neither sample worked in Teams -- I'm not sure if they ever did. the Login button pops up and then nothing happens after clicking it.
• I rarely use Auth, so a review to make sure this wouldn't break something I'm missing would be much appreciated
• As you might gather by looking through my commits, I think some code duplication can be avoided by making more calls to OAuthPrompt.GetUserTokenAsync(). @fuselabs was throwing errors when I attempted to do this, however, since it required adding , string code = null to the GetUserTokenAsync() arguments (which would make it match the Node version).

Testing

These are using the samples-work-in-progress branch:

Before

After

[fuselabs]

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll

[cleemullins]

I'm not commenting on the code correctness, as I don't have context.

... but a code change like this needs a corresponding test change. Please add a Unit Test.

[mdrichardson]

FYI: Still working on writing tests. This was more difficult than anticipated as it took me awhile to discover that TestAdapter returns a valid token regardless of the magic code (if the userId, channelId, and connectionName are the same). This is pretty key for testing this and behaves very differently than production.

[mdrichardson]

@cleemullins Tests complete.

With new OAuthPrompt:

With old OAuthPrompt:

[coveralls]

Pull Request Test Coverage Report for Build 63129

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+5.0%) to 71.155%

---

Totals
Change from base Build 56745:	5.0%
Covered Lines:	4344
Relevant Lines:	6105

---

💛 - Coveralls

[fuselabs]

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

[Jeffders]

Looks right to me. No magic code should be sent on BeginDialog. Thank you!

approved via jeff

[mdrichardson]

Note: I believe this actually bring it to parity with JS, since JS doesn't do magic code detection in BeginDialog

[fuselabs]

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

[mdrichardson]

Confirmed: JS SDK does not detect for magic code in beginDialog, which calls its own getUserToken, which also does not attempt to detect magic codes.

oauth_prompt does not exist in Python SDK. "Parity" would be making it exist. Related: microsoft/botbuilder-python#183