Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old files that are not needed any longer #1908

Merged
merged 1 commit into from
May 16, 2019

Conversation

cleemullins
Copy link
Contributor

@cleemullins cleemullins commented May 16, 2019

These files are no longer used by the build system, having been replaced with cross-platform Powershell scripts. With this, I will no longer get cranky emails on each build that say:

The page build completed successfully, but returned the following warning for the master branch:

It looks like you're using GitHub Pages to distribute binary files. We strongly suggest that you use releases to ship projects on GitHub. Releases are GitHub's way of packaging and providing software to your users. You can think of it as a replacement to using downloads to provide software. We found the following file(s) which may be a good candidate for releases: nuget/rep.exe.

@cleemullins cleemullins self-assigned this May 16, 2019
@BruceHaley
Copy link
Contributor

OK

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 59941

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.014%

Totals Coverage Status
Change from base Build 59827: 0.0%
Covered Lines: 4009
Relevant Lines: 6073

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@cleemullins cleemullins merged commit 160421b into master May 16, 2019
@cleemullins cleemullins deleted the CLM/RemoveOldBinaryBuildFiles branch May 16, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants