Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActivityPrompt documentation comments #1909

Merged
merged 1 commit into from
May 16, 2019

Conversation

v-kydela
Copy link
Contributor

The class summary had previously been copied from Prompt.cs which was misleading. The comment made it sound like ActivityPrompt was the base class of all prompts.

…iously been copied from Prompt.cs which was misleading.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 59968

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 66.014%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/ActivityPrompt.cs 13 78.57%
Totals Coverage Status
Change from base Build 59959: 0.0%
Covered Lines: 4009
Relevant Lines: 6073

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@cleemullins cleemullins merged commit 279e4fc into master May 16, 2019
@cleemullins cleemullins deleted the v-kydela/ActivityPromptComments branch May 16, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants