Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestBot] Configure an endpoint for each bot #1946

Merged
merged 4 commits into from
May 29, 2019

Conversation

gasper-az
Copy link
Contributor

@gasper-az gasper-az commented May 24, 2019

Closes #1924

Proposed Changes

  • Remove the switch-based bot assignation and its variable, and replace it with a Func<string, IBot> service.
  • Add a different endpoint for each bot to the controller.

Modifications in Pipelines

With these changes we can remove the CHOSENBOT variable from the Pipelines build and the line where we set that CHOSENBOT into Azure's WebApp.

image

image

@gasper-az gasper-az changed the title [TestBot] Configure an endpoint for each bot [Do-not merge][TestBot] Configure an endpoint for each bot May 24, 2019
@coveralls
Copy link
Collaborator

coveralls commented May 27, 2019

Pull Request Test Coverage Report for Build 61427

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.221%

Totals Coverage Status
Change from base Build 61282: 0.0%
Covered Lines: 4210
Relevant Lines: 6082

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@gasper-az gasper-az changed the title [Do-not merge][TestBot] Configure an endpoint for each bot [TestBot] Configure an endpoint for each bot May 28, 2019
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@cleemullins cleemullins merged commit 4b695ef into master May 29, 2019
@cleemullins cleemullins deleted the create-testbot-controllers branch May 29, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TestBot] Configure different controllers for each type of bot
6 participants