Adds overrides to LuisRecognizer.RecognizeAsync that take luis LuisPredictionOptions #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctionoptions. Added unit tests for the different use case. Removed IRecognizer from LuisRecognizer (it is implicit through the implementation of ITelemetryRecognizer) Updated EmptyLuisResponseClientHandler to be able to use it with the recognizer tests.
gabog
changed the title
Pull Request Test Coverage Report for Build 62323
💛 - Coveralls |
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll |
johnataylor
approved these changes
Jun 4, 2019
johnataylor
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added overrides to LuisRecognizer.RecognizeAsync that take LuisPredictionOptions.
Added unit tests for the different use case.
Removed IRecognizer from LuisRecognizer (it is implicit through the implementation of ITelemetryRecognizer)
Updated EmptyLuisResponseClientHandler to be able to use it with the recognizer tests.