Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest swagger updates #2027

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Latest swagger updates #2027

merged 2 commits into from
Jun 12, 2019

Conversation

EricDahlvang
Copy link
Member

@EricDahlvang EricDahlvang commented Jun 7, 2019 •
edited

Fixes #1944

cleemullins
cleemullins suggested changes Jun 7, 2019
View reviewed changes
libraries/Microsoft.Bot.Schema/Activity.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Schema/SemanticAction.cs Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2019 •
edited

Pull Request Test Coverage Report for Build 63253

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.155%
Totals Coverage Status
Change from base Build 63235: 0.0%
Covered Lines: 4344
Relevant Lines: 6105
💛 - Coveralls

@fuselabs
Copy link
Collaborator

fuselabs commented Jun 7, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
❌ 2 Binary Compatibility issues for Microsoft.Bot.Schema

MembersMustExist : Member 'Microsoft.Bot.Schema.Activity..ctor(System.String, System.String, System.Nullable<System.DateTimeOffset>, System.Nullable<System.DateTimeOffset>, System.String, System.String, Microsoft.Bot.Schema.ChannelAccount, Microsoft.Bot.Schema.ConversationAccount, Microsoft.Bot.Schema.ChannelAccount, System.String, System.String, System.Collections.Generic.IList<Microsoft.Bot.Schema.ChannelAccount>, System.Collections.Generic.IList<Microsoft.Bot.Schema.ChannelAccount>, System.Collections.Generic.IList<Microsoft.Bot.Schema.MessageReaction>, System.Collections.Generic.IList<Microsoft.Bot.Schema.MessageReaction>, System.String, System.Nullable<System.Boolean>, System.String, System.String, System.String, System.String, System.String, Microsoft.Bot.Schema.SuggestedActions, System.Collections.Generic.IList<Microsoft.Bot.Schema.Attachment>, System.Collections.Generic.IList<Microsoft.Bot.Schema.Entity>, System.Object, System.String, System.String, System.String, System.String, System.Object, System.String, Microsoft.Bot.Schema.ConversationReference, System.String, System.Nullable<System.DateTimeOffset>, System.String, System.String, System.Collections.Generic.IList<System.String>, System.Collections.Generic.IList<Microsoft.Bot.Schema.TextHighlight>, Microsoft.Bot.Schema.SemanticAction, System.String)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'Microsoft.Bot.Schema.SemanticAction..ctor(System.String, System.Collections.Generic.IDictionary<System.String, Microsoft.Bot.Schema.Entity>)' does not exist in the implementation but it does exist in the contract.

@fuselabs
Copy link
Collaborator

fuselabs commented Jun 7, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

This was referenced Jun 12, 2019
Closed
Closed
tomlm
tomlm approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cleemullins cleemullins merged commit 9c6e633 into master Jun 12, 2019
@cleemullins cleemullins deleted the eric/swaggerUpdates branch June 12, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@tomlm tomlm tomlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add State to Semantic Actions in Schema
5 participants
@EricDahlvang @coveralls @fuselabs @cleemullins @tomlm