Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick of 4.4 changes into master #2059

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Conversation

johnataylor
Copy link
Member

#2005 #2010 and #1979 into master

Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 64227

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 71.053%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkHttpAdapter.cs 1 69.44%
/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/TelemetryBotIdInitializer.cs 1 88.0%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs 19 53.88%
Totals Coverage Status
Change from base Build 64181: -0.09%
Covered Lines: 4352
Relevant Lines: 6125

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@johnataylor johnataylor merged commit d9dc6f6 into master Jun 12, 2019
@johnataylor johnataylor deleted the johtaylo/cherrypick44fixes branch June 12, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants