Updates project settings so it can generate nuget packages for the Testing library. #2078
Conversation
…rate nuget packages from the testing library. Removed unused ruleset and xml file. Updated csproj settings to match BotBuilder csproj
Pull Request Test Coverage Report for Build 65079
💛 - Coveralls |
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
There was a problem hiding this comment.
Per this GitHub thread:
xunit/xunit#1520
You should not be importing XUnit. Instead they are recommending:
As a reminder: If you're extending xUnit.net and want to publish your extension as a NuGet package, you should import xunit.extensibility.core and/or xunit.extensibility.execution, not xunit or xunit.core. If you do this wrong, you might have problems generating your NuGet package via dotnet pack.
…t and removed the property to force packaging (is not needed anymore)
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
Added true to the csproj file so it can generate nuget packages from the testing library.
Removed unused ruleset and xml file.
Updated csproj settings to match BotBuilder csproj
See (this)[https://stackoverflow.com/questions/48320344/cannot-create-nuget-package-that-has-xunit-as-dependency] for the solution for nuget packages not being generated for projects that reference XUnit or MSTest