Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes XML documentation for libraries. #2079

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Jun 14, 2019

Addresses: #2076
Updated all library projects to generate Xml documentaiton for the release target.
Removed unused Documentaion build configuration.
Removed junk xml files.

…lease target.

Removed unused Documentaion build configuration.
Removed junk xml files.
@gabog gabog requested a review from cleemullins June 14, 2019 21:58
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 65129

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.687%

Totals Coverage Status
Change from base Build 65083: 0.0%
Covered Lines: 4512
Relevant Lines: 6294

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you cleanup that one stray xml file (see comment) before merge?

@gabog gabog merged commit 8e287ae into master Jun 17, 2019
@gabog gabog deleted the gabog/FixXmlDocumentation branch June 17, 2019 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants