Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OnPromptAsync overload with isRetry parameter #2086

Merged
merged 7 commits into from
Jun 27, 2019
Merged

Add OnPromptAsync overload with isRetry parameter #2086

merged 7 commits into from
Jun 27, 2019

Conversation

Zerryth
Copy link
Contributor

@Zerryth Zerryth commented Jun 17, 2019 •
edited

Fixes #2004

Description

  • ActivityPrompt class in other repos include the isRetry parameter in the OnPrompt method
  • Additionally, other prompt classes in the dotnet repo itself also include this parameter (AttachmentPrompt, ChoicePrompt, Prompt.cs, etc.)
  • To remain consistent across repos and the other prompt classes, adding an OnPromptAsync overload with an isRetry parameter to the ActivityPrompt class that will allow the user to send the RetryPrompt off an activity if desired

Specific Changes

  • added OnPromptAsync() overload to ActvityPrompt class that also accepts boolean isRetry parameter
  • older OnPromptAsync() calls new OnPromptAsync() method that has isRetry parameter

@coveralls
Copy link
Collaborator

coveralls commented Jun 17, 2019 •
edited

Pull Request Test Coverage Report for Build 67776

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 182 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.4%) to 72.135%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPromptSettings.cs 1 75.0%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/DateTimeResolution.cs 2 50.0%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/PromptValidatorContext.cs 3 82.35%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/TextPrompt.cs 6 82.86%
/libraries/Microsoft.Bot.Builder/ActivityHandler.cs 7 70.91%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/ConfirmPrompt.cs 8 90.8%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/AttachmentPrompt.cs 8 74.29%
/libraries/Microsoft.Bot.Builder.Dialogs/Dialog.cs 8 67.86%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/NumberPrompt.cs 9 89.77%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/ActivityPrompt.cs 10 87.64%
Totals Coverage Status
Change from base Build 65465: 0.4%
Covered Lines: 4551
Relevant Lines: 6309
💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@Zerryth Zerryth marked this pull request as ready for review June 20, 2019 18:30
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@Zerryth Zerryth requested a review from johnataylor June 20, 2019 18:40
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

gabog
gabog suggested changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@gabog gabog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ashley, check the comment on reprompt and let me know what you think.

libraries/Microsoft.Bot.Builder.Dialogs/Prompts/ActivityPrompt.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs/Prompts/ActivityPrompt.cs Outdated Show resolved Hide resolved
@Zerryth
Copy link
Contributor Author

Zerryth commented Jun 27, 2019

@gabog edited the ActivityPromptResumeDialogShouldReturnDialogEndOfTurn() test, which passes with RepromptDialogAsync() with isRetry as true and fails if we leave it as false, without the false positive like before 👍

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@Zerryth Zerryth merged commit 6868160 into master Jun 27, 2019
@Zerryth Zerryth deleted the Zerryth/OnPromptIsRetryParam branch June 27, 2019 23:10
@Zerryth Zerryth mentioned this pull request Aug 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabog gabog gabog approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialogs Parity w/JS Repo -- Dotnet Missing isRetry Parameter
4 participants
@Zerryth @coveralls @fuselabs @gabog