Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue 1960 private to public #2117

Merged
merged 1 commit into from
Jun 24, 2019
Merged

issue 1960 private to public #2117

merged 1 commit into from
Jun 24, 2019

Conversation

johnataylor
Copy link
Member

  • make DialogContext constructor public (it was internal) this was a customer ask from two independent sources
  • make DelegatingTurnContext protected rather than private in ActivityHandler - this allows derived classes to also get the benefit of slightly stronger typing (this was really a bug as ActivityHandler was intended for extensibility through inheritance)

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 66903

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.942%
Totals Coverage Status
Change from base Build 66757: 0.0%
Covered Lines: 4528
Relevant Lines: 6294
💛 - Coveralls

@fuselabs
Copy link
Collaborator

❌ 1 Binary Compatibility issues for Microsoft.Bot.Builder compared against version 4.3.1

CannotMakeMoreVisible : Visibility of type 'Microsoft.Bot.Builder.ActivityHandler.DelegatingTurnContext<T>' is 'Family' in the implementation but 'Private' in the contract.

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

tomlm
tomlm approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit 65157eb into master Jun 24, 2019
@tomlm tomlm deleted the johtaylo/make-protected branch June 24, 2019 17:50
gabog
gabog reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@gabog gabog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cleemullins cleemullins restored the johtaylo/make-protected branch June 25, 2019 01:04
@cleemullins cleemullins mentioned this pull request Jun 25, 2019
Merged
@cleemullins
Copy link
Contributor

This was reverted. I also "undeleted" the branch so it can be worked on.

@cleemullins cleemullins deleted the johtaylo/make-protected branch September 12, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabog gabog gabog left review comments

@tomlm tomlm tomlm approved these changes

@cleemullins cleemullins Awaiting requested review from cleemullins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@johnataylor @coveralls @fuselabs @cleemullins @gabog @tomlm