-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrimc/geo #2139
Chrimc/geo #2139
Conversation
…into model. Need to update tests to be able to verify both on the same oracle files if possible.
@BruceHaley @cleemullins @chrimc62 the tests are failing due to a missing environment variable: Failed TypedPrebuiltDomains
Error Message:
Test method Microsoft.Bot.Builder.AI.Luis.Tests.LuisOracleTests.TypedPrebuiltDomains threw exception:
System.Exception: Environment variable 'LuisSubscriptionKey' not found.
Stack Trace:
at Microsoft.Bot.Builder.AI.Luis.Tests.LuisOracleTests.GetEnvironmentVarsLuis() in d:\a\1\s\tests\Microsoft.Bot.Builder.AI.LUIS.Tests\LuisOracleTests.cs:line 1233
at Microsoft.Bot.Builder.AI.Luis.Tests.LuisOracleTests.TestJson[T](String file) in d:\a\1\s\tests\Microsoft.Bot.Builder.AI.LUIS.Tests\LuisOracleTests.cs:line 478
at Microsoft.Bot.Builder.AI.Luis.Tests.LuisOracleTests.TypedPrebuiltDomains() in d:\a\1\s\tests\Microsoft.Bot.Builder.AI.LUIS.Tests\LuisOracleTests.cs:line 560 The |
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the project name "LuisPreview" so it matches the namespace? Having "-preview"
libraries/Microsoft.Bot.Builder.AI.LUIS-preview/LuisApplication.cs
Outdated
Show resolved
Hide resolved
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits.
libraries/Microsoft.Bot.Builder.AI.LUIS/Generator/GeographyV2.cs
Outdated
Show resolved
Hide resolved
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
Fix #1661
Update LUIS Recognizer to support GeographyV2, OrdinalV2 and PersonName from LUIS. Includes updating tests as well. Required to support the same features in LUISGen. Also moved back from functional tests to regular tests.