Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove at mention for INSPECT #2159

Merged
merged 2 commits into from
Jul 2, 2019
Merged

remove at mention for INSPECT #2159

merged 2 commits into from
Jul 2, 2019

Conversation

johnataylor
Copy link
Member

fixes #2060

@coveralls
Copy link
Collaborator

coveralls commented Jul 2, 2019

Pull Request Test Coverage Report for Build 68337

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 77.115%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder/Inspection/InspectionMiddleware.cs 25 79.55%
Totals Coverage Status
Change from base Build 68166: 0.01%
Covered Lines: 4896
Relevant Lines: 6349

💛 - Coveralls

@fuselabs
Copy link
Collaborator

fuselabs commented Jul 2, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@johnataylor
Copy link
Member Author

I also found a couple of fragile cases in the new TestBot tests - tomorrow doesn't always equal today + 1. Had to fix so this passes.

JavaScript seems to be missing the whole mention filtering code - that is a different (and bigger) issue. Possibly its just that I haven't found it yet!

@johnataylor johnataylor requested a review from gabog July 2, 2019 02:21
@fuselabs
Copy link
Collaborator

fuselabs commented Jul 2, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johnataylor johnataylor merged commit 0cec82c into master Jul 2, 2019
@johnataylor johnataylor deleted the johtaylo/issue2060 branch July 2, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/INSPECT attach command does not work in MSTeams channel conversations
4 participants