You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed XUnitOutputMiddleware to XUnitDialogTestLogger (so its name is closer to js).
Added some spaces to the XUnitDialogTestLogger output so it reads better.
Removed callback constructor parameter from DialogTestClient (it relies on an internal DialogTurnResult and that's fishy, we will need to find a better solution in the future to support this).
Added optional ConversationState parameter to the DialogTestClient constructor and exposed a property to allow people to inspect it or access it.
…s closer to js).
Added some spaces to the XUnitDialogTestLogger output so it reads better.
Removed callback constructor parameter from DialogTestClient (it relies on an internal DialogTurnResult, we will need to find a better solution in the future to support this).
Added optional ConversationState parameter to the constructor and exposed a property to allow people to inspect it or access it.
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1
The reason will be displayed to describe this comment to others. Learn more.
In some tests, they may need to write some preconditions in ConversationState, I looked at some of the VA dialogs and other projects and in some scenarios they cache user information and other info when a conversation starts that's then used by the dialogs.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed XUnitOutputMiddleware to XUnitDialogTestLogger (so its name is closer to js).
Added some spaces to the XUnitDialogTestLogger output so it reads better.
Removed callback constructor parameter from DialogTestClient (it relies on an internal DialogTurnResult and that's fishy, we will need to find a better solution in the future to support this).
Added optional ConversationState parameter to the DialogTestClient constructor and exposed a property to allow people to inspect it or access it.