Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streaming Extensions] Preview build of Streaming Extensions package #2201

Merged
merged 85 commits into from
Jul 10, 2019
Merged

[Streaming Extensions] Preview build of Streaming Extensions package #2201

merged 85 commits into from
Jul 10, 2019

Conversation

DDEfromOR
Copy link
Member

Support for Dot Net Core only, no integration with Bot Builder, GMO free, hand crafted, artisanal code.

@DDEfromOR
Add protocol packages to libraries dir.
53b5108
@DDEfromOR
First step of redesign for integration
3cf933a
@DDEfromOR
Add SE core project to solution
578391a
@DDEfromOR
Add unit tests
3ef0a01
@DDEfromOR
Rebrand
be53969
@DDEfromOR
Integration step 2
63e2716
@DDEfromOR
Further integration. Namespace changes, some dependency changes.
f556688
@DDEfromOR
Remove NetFx target
be38114
@DDEfromOR
Consolidate nuget package versions
ac7413c
@DDEfromOR
Fix dependency conflicts
3345fc3
@DDEfromOR
Address style issues in core protocol
d0c9af9
@DDEfromOR
Fix project references, get WebAPi integration to build.
cd68e83
@DDEfromOR
Namespace cleanup and assembly updates to reveal internal methods to …
a0a895e 
…unit tests.
@DDEfromOR
Bring over remaining tests
1654f9e
@DDEfromOR
Address low hanging fruit style cop warnings.
f789b73
@DDEfromOR
Medium risk style fixes.
2b9a232
@DDEfromOR
More fruit!
aa98893
@DDEfromOR
partial cleanup of adapter
56ff30a
@DDEfromOR
Reduce surface area, pipe onturnerror thru to adapter
73afed6
@DDEfromOR
Reduce surface area, add null checks
ddd28a5
@DDEfromOR
internalize assemblers and disassemblers
5eb9e18
@DDEfromOR
internalize payloads
95dd9b1
@DDEfromOR
internalized everything possible for first pass
f1a2d2b
@DDEfromOR
More surface space reduction
8eef047
@DDEfromOR
// Copyright (c) Microsoft Corporation. All rights reserved.
e384265 
// Licensed under the MIT License.
@DDEfromOR
Adjustments to maintain testability of internal classes and methods
72274aa
@DDEfromOR
Add summaries and null checks to all public methods in Streaming Exte…
ca2b8e3 
…nsions library.
@DDEfromOR
More null checks and summaries
868c38b
@DDEfromOR
remove using
7b4dd53
@DDEfromOR
Remove automatic addition to csproj
be2b91e
@DDEfromOR
Add default empty set for Streams
750900c
@DDEfromOR
Return empty strings instead of nulls
931580f
@DDEfromOR
Added some comments explaining headers
2962f64
@DDEfromOR
Revert change, this throw is too dangerous and will drop multiplexed …
d7b1cc1 
…connections over a single bad request.
@DDEfromOR
Update tests to reflect changes in code
2570d38
@DDEfromOR
Refactor contentstream to make the stream readonly.
cf970e5
@DDEfromOR
Remove GetStream from ContentStream, make it a property instead, refa…
88541ae 
…ctor accordingly
@DDEfromOR
Change Type to the more accurate and less reserved name ContentType
3bc66c9
@DDEfromOR
Remove unused OperationException, update properties in project file.
82a724b
@DDEfromOR
Some renaming for clarity
0363414
@DDEfromOR
Relocate stream classes to payloads
2d42ac6
@DDEfromOR
Major overhaul of assemblers. Removed abstract PayloadAssembler, intr…
2248b9c 
…oduced IAssembler interface as a replacement, implemented all methods on the three children classes.
@DDEfromOR
Name changes and cleanup
c3f1e37
@DDEfromOR
Log errors instead of information when something goes wrong.
ee80782
@DDEfromOR
Add second ctor to named pipe connector for use with the default pipe…
323ec69 
… name
@DDEfromOR
Revert two over zealous changes, but add comments explaining why the …
c6e97f4 
…code is important.
@DDEfromOR
Refactor into one assembly
5dc4fc5
@DDEfromOR
Remove auto-code from bot builder proj file
4feceaf
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 69485

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.089%
Totals Coverage Status
Change from base Build 69049: 0.0%
Covered Lines: 4963
Relevant Lines: 6438
💛 - Coveralls

@fuselabs
Copy link
Collaborator

fuselabs commented Jul 9, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@DDEfromOR DDEfromOR changed the title Preview build of Streaming Extensions package [Streaming Extensions] Preview build of Streaming Extensions package Jul 9, 2019
@cleemullins
Copy link
Contributor

TEst that's failing is known as bad, and already fixed in master. Has nothing to do with this PR.

@cleemullins cleemullins merged commit 89bc33f into master Jul 10, 2019
@cleemullins cleemullins deleted the dev/streaming-extensions-preview-branch branch July 10, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DDEfromOR @coveralls @fuselabs @cleemullins