Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming Extensions] Updates to split Streaming Extensions library into two packages. #2221

Merged
merged 6 commits into from
Jul 11, 2019

Conversation

DDEfromOR
Copy link
Member

This PR moves the classes previously contained in the Microsoft.Bot.StreamingExtensions.Integration namespace to a newly created package named Microsoft.Bot.Builder.StreamingExtensions. These classes are used only by bots and cannot be included in the core StreamingExtensions library due to dependencies on Bot Builder.

@coveralls
Copy link
Collaborator

coveralls commented Jul 11, 2019

Pull Request Test Coverage Report for Build 70231

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.089%

Totals Coverage Status
Change from base Build 69959: 0.0%
Covered Lines: 4963
Relevant Lines: 6438

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@cleemullins cleemullins merged commit b025aaa into master Jul 11, 2019
@cleemullins cleemullins deleted the se/dlase branch July 11, 2019 21:37
@cleemullins
Copy link
Contributor

cleemullins commented Jul 11, 2019

Review + Changes made in person w/ Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants