[Botkit] Migrate Webex Adapter #2238

ceciliaavila · 2019-07-12T20:27:20Z

Proposed Changes

Migrated the Webex Adapter from the Botkit repo.

Details

Migrated classes:

WebexAdapter
WebexAdapterOptions

Helper classes:

WebexHelper
WebexClientWrapper
AttachmentActionData
WebexMessageRequest

coveralls · 2019-07-12T21:32:41Z

Pull Request Test Coverage Report for Build 79943

0 of 0 changed or added relevant lines in 0 files are covered.
333 unchanged lines in 56 files lost coverage.
Overall coverage decreased (-0.9%) to 80.338%

Files with Coverage Reduction	New Missed Lines	%
/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Twilio/TwilioAdapter.cs	1	85.71%
/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs	1	71.43%
/libraries/Microsoft.Bot.Builder/ActivityHandler.cs	1	9.72%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs	1	95.45%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/PromptValidatorContext.cs	1	82.35%
/libraries/Microsoft.Bot.Builder.Dialogs/WaterfallStepContext.cs	1	86.96%
/libraries/Microsoft.Bot.Builder/TelemetryLoggerMiddleware.cs	1	57.58%
/libraries/Microsoft.Bot.Builder.Testing/XUnit/TestDataObject.cs	1	82.35%
/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Twilio/TwilioClientWrapper.cs	2	0.0%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/HttpHelper.cs	2	90.91%

Totals
Change from base Build 79839:	-0.9%
Covered Lines:	4854
Relevant Lines:	6042

💛 - Coveralls

fuselabs · 2019-07-12T21:34:55Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-07-16T21:01:26Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-07-24T13:10:46Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-07-24T13:32:16Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-08-15T21:01:06Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-08-16T20:37:58Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-08-20T20:44:48Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-08-21T21:08:46Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-08-22T21:08:20Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-08-23T21:14:35Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-08-27T20:24:45Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-08-28T21:01:50Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

benbrown

We should add the new functionality from Webex, which includes:

a new event type for receiving adaptive card submissions
a secondary webhook subscription to request these events
a new API call to decrypt these events
a slightly different mapping of these events into Activities

This is all present in the current botbuilder-adapter-webex

libraries/Adapters/Microsoft.Bot.Builder.Adapters.Webex/WebexAdapter.cs

benbrown · 2019-08-29T15:27:12Z

I think if possible we should expose more of the webex client as a public member of the adapter so that developers will have automatic access to all of the webex apis. The APIs used within the adapter are important, but developers will frequently need others and if we provide it via the adapter they don't have to create another instance of the same class.

benbrown · 2019-08-29T15:35:32Z

Here is the diff from when I added these new features to Botkit:

howdyai/botkit@d0ed5ab...master

fuselabs · 2019-08-29T20:32:53Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

ceciliaavila · 2019-08-29T20:57:20Z

I think if possible we should expose more of the webex client as a public member of the adapter so that developers will have automatic access to all of the webex apis. The APIs used within the adapter are important, but developers will frequently need others and if we provide it via the adapter they don't have to create another instance of the same class.

Yes, it sounds good. Once we finished the migration of the Adaptive Cards functionality, we can take this task.
Thanks!

fuselabs · 2019-08-29T21:05:37Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-09-18T18:18:47Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-09-18T19:41:53Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-09-20T13:44:04Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-09-20T14:35:04Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-09-20T15:10:56Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

cleemullins · 2019-09-20T17:07:19Z

Mergning, now that @benbrown has signed off via email.

"I think we are good to merge! "

ceciliaavila changed the title ~~[Botkit] Migrate Webex Adapter from Botkit~~ [Botkit] Migrate Webex Adapter Jul 12, 2019

ceciliaavila force-pushed the add/webex-adapter branch from 1ddbbe0 to 6234889 Compare July 12, 2019 21:22

ceciliaavila marked this pull request as ready for review July 19, 2019 11:50

ceciliaavila force-pushed the add/webex-adapter branch from 2080619 to d270d90 Compare July 24, 2019 12:58

ceciliaavila force-pushed the add/webex-adapter branch from d270d90 to b7ae0ad Compare July 24, 2019 13:20

cleemullins assigned gabog Jul 25, 2019

gasper-az force-pushed the add/webex-adapter branch from b7ae0ad to f458185 Compare August 15, 2019 20:49

gasper-az changed the title ~~[Botkit] Migrate Webex Adapter~~ [Do Not Merge] - [Botkit] Migrate Webex Adapter Aug 15, 2019

cleemullins mentioned this pull request Aug 23, 2019

[Question] How to implement Transcript store on Twitter Adapter BotBuilderCommunity/botbuilder-community-dotnet#141

Closed

ceciliaavila changed the title ~~[Do Not Merge] - [Botkit] Migrate Webex Adapter~~ [Botkit] Migrate Webex Adapter Aug 28, 2019

benbrown suggested changes Aug 29, 2019

View reviewed changes

libraries/Adapters/Microsoft.Bot.Builder.Adapters.Webex/WebexAdapter.cs Outdated Show resolved Hide resolved

ceciliaavila force-pushed the add/webex-adapter branch from 3ee02ab to 2dbc83f Compare August 29, 2019 20:54

ceciliaavila added 12 commits September 18, 2019 08:50

Move GetIdentityAsync call inside the adapter

6f879df

Make CancellationToken parameter mandatory

cb5615e

Remove underscores from tests names

b8b52d8

Move methods to WebexClientWrapper class

959bd54

Update unit tests

63cdc6f

Remove cancellationToken.Register

c439e51

Throw ArgumentException in wrapper class const.

e4413f9

Add a descriptive name for self-message events

21f26ff

Fix Regexes for messages with html

d3e7b5a

remove commented line

ced5bce

Fix Regex and tests when mention id is decoded

e83ecdd

Remove unnecessary using statements

3db73f8

gabog approved these changes Sep 18, 2019

View reviewed changes

ceciliaavila and others added 2 commits September 18, 2019 14:34

Add Id decoding to strip mention in messages html

0a7e276

Add WebEx adapter project to CodeCoverage

1414224

ceciliaavila force-pushed the add/webex-adapter branch from c9d598a to 1414224 Compare September 18, 2019 18:05

Fix parameter documentation

5d0abc8

ceciliaavila mentioned this pull request Sep 18, 2019

[Feature Request][Webex Adapter] Move non-related methods from the adapter howdyai/botkit#1814

Closed

ceciliaavila and others added 2 commits September 20, 2019 10:21

Exclude from CC POCO and Wrapper classes

4c8f9ad

Exclude from CC POCO and Wrapper classes

c3f49d7

Exclude classes from CC using .runsettings file

64af50e

Merge branch 'master' into add/webex-adapter

25a70b3

cleemullins merged commit 69796e3 into master Sep 20, 2019

cleemullins deleted the add/webex-adapter branch September 20, 2019 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Botkit] Migrate Webex Adapter #2238

[Botkit] Migrate Webex Adapter #2238

ceciliaavila commented Jul 12, 2019 •

edited

coveralls commented Jul 12, 2019 •

edited

fuselabs commented Jul 12, 2019

fuselabs commented Jul 16, 2019

fuselabs commented Jul 24, 2019

fuselabs commented Jul 24, 2019

fuselabs commented Aug 15, 2019

fuselabs commented Aug 16, 2019

fuselabs commented Aug 20, 2019

fuselabs commented Aug 21, 2019

fuselabs commented Aug 22, 2019

fuselabs commented Aug 23, 2019

fuselabs commented Aug 27, 2019

fuselabs commented Aug 28, 2019

benbrown left a comment

benbrown commented Aug 29, 2019

benbrown commented Aug 29, 2019

fuselabs commented Aug 29, 2019

ceciliaavila commented Aug 29, 2019

fuselabs commented Aug 29, 2019

fuselabs commented Sep 18, 2019

fuselabs commented Sep 18, 2019

fuselabs commented Sep 20, 2019

fuselabs commented Sep 20, 2019

fuselabs commented Sep 20, 2019

cleemullins commented Sep 20, 2019

[Botkit] Migrate Webex Adapter #2238

[Botkit] Migrate Webex Adapter #2238

Conversation

ceciliaavila commented Jul 12, 2019 • edited

Proposed Changes

Details

coveralls commented Jul 12, 2019 • edited

Pull Request Test Coverage Report for Build 79943

💛 - Coveralls

fuselabs commented Jul 12, 2019

fuselabs commented Jul 16, 2019

fuselabs commented Jul 24, 2019

fuselabs commented Jul 24, 2019

fuselabs commented Aug 15, 2019

fuselabs commented Aug 16, 2019

fuselabs commented Aug 20, 2019

fuselabs commented Aug 21, 2019

fuselabs commented Aug 22, 2019

fuselabs commented Aug 23, 2019

fuselabs commented Aug 27, 2019

fuselabs commented Aug 28, 2019

benbrown left a comment

Choose a reason for hiding this comment

benbrown commented Aug 29, 2019

benbrown commented Aug 29, 2019

fuselabs commented Aug 29, 2019

ceciliaavila commented Aug 29, 2019

fuselabs commented Aug 29, 2019

fuselabs commented Sep 18, 2019

fuselabs commented Sep 18, 2019

fuselabs commented Sep 20, 2019

fuselabs commented Sep 20, 2019

fuselabs commented Sep 20, 2019

cleemullins commented Sep 20, 2019

ceciliaavila commented Jul 12, 2019 •

edited

coveralls commented Jul 12, 2019 •

edited