Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts PR 1993 #2259

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Reverts PR 1993 #2259

merged 1 commit into from
Jul 16, 2019

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Jul 16, 2019

This PR reverts changed made in #1993.

At this moment, is not possible to return cancelled from a component dialog.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 71076

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 77.061%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/ComponentDialog.cs 12 78.16%
Totals Coverage Status
Change from base Build 70288: -0.03%
Covered Lines: 4955
Relevant Lines: 6430

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@gabog gabog requested a review from cleemullins July 16, 2019 22:26
@cleemullins cleemullins marked this pull request as ready for review July 16, 2019 23:34
@cleemullins cleemullins merged commit b7245a3 into master Jul 16, 2019
@cleemullins cleemullins deleted the gabog/reverts1993 branch July 16, 2019 23:34
@cleemullins cleemullins mentioned this pull request Jul 16, 2019
@sgellock sgellock mentioned this pull request Nov 6, 2019
11 tasks
@ghost
Copy link

ghost commented Jan 16, 2020

Do we know why this was reverted? It would be helpful if the correct reason is passed to the next step in a waterfall dialog when a Dialog in the previous step has been cancelled.

@gabog
Copy link
Contributor Author

gabog commented Jan 16, 2020

We reverted because it was cancelling the entire dialog stack rather than just the leaf dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants