[Botkit] Add Twilio adapter port #2290

ceciliaavila · 2019-07-19T21:10:47Z

Proposed Changes

Migrated the Twilio SMS adapter from the Botkit repo.

Details

Migrated classes:

TwilioAdapter
ITwilioAdapterOptions (interface)
TwilioEvent

Note: There's a sample bot included in tests -> Test Applications ->Microsoft.Bot.Builder.Twilio.Sample for testing purposes. It will be removed before merging

coveralls · 2019-07-19T21:21:07Z

Pull Request Test Coverage Report for Build 74937

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+1.9%) to 80.434%

Files with Coverage Reduction	New Missed Lines	%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs	1	56.41%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs	2	50.0%

Totals
Change from base Build 73181:	1.9%
Covered Lines:	3519
Relevant Lines:	4375

💛 - Coveralls

fuselabs · 2019-07-19T21:22:25Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-07-30T19:55:52Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-07-30T20:10:21Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

* Apply naming convention * Replace explicit type with var * Remove unnecessary 'this', Fix extra naming * Remove unnecessary '.ToString()' * Use object initializer * Remove explicit type * Use a more descriptive exception class

fuselabs · 2019-07-30T21:08:43Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-07-31T14:30:03Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

tomlm

libraries/Adapters/Microsoft.Bot.Builder.Adapters.Twilio/TwilioAdapter.cs

gabog

Please hold on merging until I get a chance to review

…dynamic-free [Botkit][Twilio] Remove 'as dynamic' casting

…l-string-condition [Botkit][Twilio] Improve null string conditions

Add ActivityToTwilio_Should_Fail_With_Null_Activity ActivityToTwilio_Should_Return_Null_With_Empty_Or_Invalid_Number Modify TwilioAdapterTests

fuselabs · 2019-08-08T21:10:36Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

.../Adapters/Microsoft.Bot.Builder.Adapters.Twilio/Microsoft.Bot.Builder.Adapters.Twilio.csproj

…nNumeric_NumMedia

Renamed RequestToActivity_Should_Return_Activity_EmptyAttachments_With_NonNumeric_NumMedia to RequestToActivity_Should_Return_Null_Activity_Attachments_With_NumMedia_EqualToZero

Added ActivityToTwilio_Should_Return_Empty_MediaUrl_With_Null_MediaUrls RequestToActivity_Should_Return_Null_With_Null_HttpRequest

…a_GreaterThanZero Added RequestToActivity_Should_Return_Activity_Attachments_With_NumMedia_GreaterThanZero ProcessAsync_Should_Succeed_With_HttpBody (Skipped) ProcessAsync_Should_Succeed_With_Null_HttpBody (Skipped)

fuselabs · 2019-08-09T21:22:43Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

Remove Sample bot

fuselabs · 2019-08-12T21:44:12Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

cleemullins assigned gabog Jul 25, 2019

ceciliaavila force-pushed the add/twilio-adapter branch 2 times, most recently from 1892bcf to ce5f8f7 Compare July 27, 2019 00:10

ceciliaavila marked this pull request as ready for review July 27, 2019 00:10

ceciliaavila force-pushed the add/twilio-adapter branch from ce5f8f7 to 224f60c Compare July 30, 2019 17:25

ceciliaavila and others added 3 commits July 30, 2019 16:31

Add Twilio Adapter

67cc4da

Add Botkit project

0315ab0

Remove package Botkit

ff43c59

ceciliaavila force-pushed the add/twilio-adapter branch from 224f60c to 602ede3 Compare July 30, 2019 19:44

ceciliaavila force-pushed the add/twilio-adapter branch from 602ede3 to 945fc1b Compare July 30, 2019 19:59

VictorGrycuk and others added 2 commits July 30, 2019 17:47

Apply naming convention and other improvements

778438e

* Apply naming convention * Replace explicit type with var * Remove unnecessary 'this', Fix extra naming * Remove unnecessary '.ToString()' * Use object initializer * Remove explicit type * Use a more descriptive exception class

Add TODO comment

e46acd2

ceciliaavila force-pushed the add/twilio-adapter branch from 945fc1b to e46acd2 Compare July 30, 2019 20:57

Add test App for Twilio

a570cc1

ceciliaavila added 3 commits July 31, 2019 09:21

Fix property naming

eee0173

Remove unused property and using statement

280facd

Remove 'as dynamic' casting

9f1f339

tomlm approved these changes Jul 31, 2019

View reviewed changes

iMicknl reviewed Jul 31, 2019

View reviewed changes

libraries/Adapters/Microsoft.Bot.Builder.Adapters.Twilio/TwilioAdapter.cs Outdated Show resolved Hide resolved

gabog suggested changes Jul 31, 2019

View reviewed changes

ceciliaavila and others added 4 commits July 31, 2019 14:27

Merge pull request #158 from southworkscom/botkit/adapters/twilio-as-…

e714775

…dynamic-free [Botkit][Twilio] Remove 'as dynamic' casting

Use IsNullOrWhiteSpace to validate str conditions

ff1ed29

Fix ReSharper warnings

8b74529

Merge pull request #159 from southworkscom/botkit/adapters/twilio-nul…

09ef94c

…l-string-condition [Botkit][Twilio] Improve null string conditions

ceciliaavila and others added 2 commits August 8, 2019 15:43

Add test for TwilioAdapter and TwilioHelper

152808c

Add ActivityToTwilio tests

4ba3d2f

Add ActivityToTwilio_Should_Fail_With_Null_Activity ActivityToTwilio_Should_Return_Null_With_Empty_Or_Invalid_Number Modify TwilioAdapterTests

cleemullins reviewed Aug 8, 2019

View reviewed changes

.../Adapters/Microsoft.Bot.Builder.Adapters.Twilio/Microsoft.Bot.Builder.Adapters.Twilio.csproj Show resolved Hide resolved

matiasroldan6 and others added 15 commits August 9, 2019 09:54

Add twilio helper tests

8f001ed

Add RequestToActivity_Should_Return_Activity_EmptyAttachments_With_No…

4e571ff

…nNumeric_NumMedia

Test renamed

60d031d

Renamed RequestToActivity_Should_Return_Activity_EmptyAttachments_With_NonNumeric_NumMedia to RequestToActivity_Should_Return_Null_Activity_Attachments_With_NumMedia_EqualToZero

Add QueryStringToDictionary_Should_Return_Dictionary_With_Valid_Query

b88c517

Add helper tests

8072f7c

Added ActivityToTwilio_Should_Return_Empty_MediaUrl_With_Null_MediaUrls RequestToActivity_Should_Return_Null_With_Null_HttpRequest

Extract Twilio API to a class and interface

599d023

Implement ITwilioClient in TwilioAdapter

7f7a61b

Update Twilio Sample Bot

62d77d6

Update tests to use a mocked ITwilioClient

76987f5

Add test for successful SendActivitiesAsync

c84210f

Add test for null TwilioClient in constructor

c482043

Add documentation comments to TwilioApi

e7b64d1

Add documentation for ITwilioClient

3c29ff9

Add additional unit tests for Twilio and extract Twilio Rest API

0f0bb95

VictorGrycuk and others added 4 commits August 12, 2019 16:00

Remove Sample Bot files

3c372c8

Merge pull request #173 from southworkscom/twilio/remove-sample-bot

deca215

Remove Sample bot

Do minimal polish to TwilioHelperTests (#174)

d1d331a

Removed Twilio.Testbot project

93ac24d

cleemullins approved these changes Aug 13, 2019

View reviewed changes

cleemullins merged commit a5e1a04 into master Aug 13, 2019

cleemullins deleted the add/twilio-adapter branch August 13, 2019 18:00

BruceHaley mentioned this pull request Aug 15, 2019

Fix signing build BotBuilder-DotNet-Signed-daily #190814-1 #2414

Merged

gabog mentioned this pull request Aug 29, 2019

Twilio adapter/add twilio testbot microsoft/BotBuilder-Samples#1737

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Botkit] Add Twilio adapter port #2290

[Botkit] Add Twilio adapter port #2290

ceciliaavila commented Jul 19, 2019 •

edited

coveralls commented Jul 19, 2019 •

edited

fuselabs commented Jul 19, 2019

fuselabs commented Jul 30, 2019

fuselabs commented Jul 30, 2019

fuselabs commented Jul 30, 2019

fuselabs commented Jul 31, 2019

tomlm left a comment

gabog left a comment

fuselabs commented Aug 8, 2019

fuselabs commented Aug 9, 2019

fuselabs commented Aug 12, 2019

[Botkit] Add Twilio adapter port #2290

[Botkit] Add Twilio adapter port #2290

Conversation

ceciliaavila commented Jul 19, 2019 • edited

Proposed Changes

Details

coveralls commented Jul 19, 2019 • edited

Pull Request Test Coverage Report for Build 74937

💛 - Coveralls

fuselabs commented Jul 19, 2019

fuselabs commented Jul 30, 2019

fuselabs commented Jul 30, 2019

fuselabs commented Jul 30, 2019

fuselabs commented Jul 31, 2019

tomlm left a comment

Choose a reason for hiding this comment

gabog left a comment

Choose a reason for hiding this comment

fuselabs commented Aug 8, 2019

fuselabs commented Aug 9, 2019

fuselabs commented Aug 12, 2019

ceciliaavila commented Jul 19, 2019 •

edited

coveralls commented Jul 19, 2019 •

edited