Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwilioAdapter] Replace TwilioAdapter bare Exceptions #2420

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

gasper-az
Copy link
Contributor

Fix ISSUE #2415

Description

Replaced bare Exception with ArgumentException and ArgumentNullException in the TwilioAdapter.cs file. Also updated the related test methods.

More Details

Replaced TwilioAdapter's constructor bare Exception with ArgumentException and ArgumentNullException respectively.
image

Also, updated SendActivitiesAsync method for replacing an Exception an ArgumentException:
image

All the test methods successfully passed:
image

Replaced TwilioAdapter constructor's Exception with ArgumentException and ArgumentNullException, and updated the related Test methods.
Replaced TwilioAdapter.SendActivitiesAsync Exception with ArgumentException, and updated the related test method
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@cleemullins cleemullins merged commit f5dd0fc into master Aug 16, 2019
@cleemullins cleemullins deleted the fix/twilio/change-exception-types branch August 16, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants