-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Add changes of recognizers-text utterances to the package description #2442
Conversation
1c281ba
to
1a4bf02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good step towards informing users of the recognizers library upgrade.
However, this might now conflict with https://github.com/microsoft/botbuilder-dotnet/pull/2448/files which is also upgrading these same references.
Dismissing review because this PR should not be upgrading the recognizers references. (that is in 2448)
libraries/Microsoft.Bot.Builder.Dialogs/Microsoft.Bot.Builder.Dialogs.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to do this.
This should go in the release notes, but I don't know if it should go here.
@cleemullins how about adding a link to the release notes here? And mention the recognizers upgrade, but without the details? |
Description
This PR adds a temporal description to the
.csproj
ofMicrosoft.Bot.Builder
andMicrosoft.Bot.Builder.Dialogs
that includes the changes that come with the Recognizers-Text version upgrade.Changes made
Microsoft.Bot.Builder.csproj
Microsoft.Bot.Builder.Dialogs
Result
This is what the preview looks like when the package is generated:
Note: This is a temporal solution, in the future the release note should be changed. If the NuGet team adds the option to add markdown, we would probably want to link the changes instead of writing them down. However, this will do for an initial version upgrade.