Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Add changes of recognizers-text utterances to the package description #2442

Merged
merged 3 commits into from
Aug 28, 2019

Conversation

Aliandi
Copy link
Contributor

@Aliandi Aliandi commented Aug 22, 2019

Description

This PR adds a temporal description to the .csproj of Microsoft.Bot.Builder and Microsoft.Bot.Builder.Dialogs that includes the changes that come with the Recognizers-Text version upgrade.

Changes made

  • Add description to Microsoft.Bot.Builder.csproj
  • Add description to Microsoft.Bot.Builder.Dialogs

Result

This is what the preview looks like when the package is generated:

imagen

Note: This is a temporal solution, in the future the release note should be changed. If the NuGet team adds the option to add markdown, we would probably want to link the changes instead of writing them down. However, this will do for an initial version upgrade.

@Aliandi Aliandi changed the title [Documentation] Add changes on recognizers-text utterances to the package description [Documentation] Add changes of recognizers-text utterances to the package description Aug 22, 2019
EricDahlvang
EricDahlvang previously approved these changes Aug 27, 2019
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good step towards informing users of the recognizers library upgrade.

However, this might now conflict with https://github.com/microsoft/botbuilder-dotnet/pull/2448/files which is also upgrading these same references.

@EricDahlvang EricDahlvang dismissed their stale review August 27, 2019 21:29

Dismissing review because this PR should not be upgrading the recognizers references. (that is in 2448)

@cleemullins cleemullins merged commit 580c03d into microsoft:master Aug 28, 2019
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to do this.

This should go in the release notes, but I don't know if it should go here.

@EricDahlvang
Copy link
Member

@cleemullins how about adding a link to the release notes here? And mention the recognizers upgrade, but without the details?

@gasper-az gasper-az deleted the release-note-docs branch September 13, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants