Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Recognizers-Text version from v1.1.3 to v1.2.6 #2448

Merged
merged 3 commits into from
Aug 28, 2019

Conversation

Aliandi
Copy link
Contributor

@Aliandi Aliandi commented Aug 23, 2019

Description

This PR upgrades the version of Recognizers-Text from v1.1.3 to v1.2.6 (latest stable version).

Changes made

  • Change versions of Microsoft.Recognizers.Text.Choice and Microsoft.Recognizers.Text.DateTime on Microsoft.Bot.Builder.Dialogs to v.1.2.6
  • Add NumberOptions.SuppressExtendedTypes to the NumberRecognizer in ChoiceRecognizers

Testing

imagen

EricDahlvang
EricDahlvang previously approved these changes Aug 27, 2019
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovered another spot requiring SuppressExtendedTypes

@EricDahlvang EricDahlvang dismissed their stale review August 27, 2019 20:23

Discovered

var results = NumberRecognizer.RecognizeNumber(message.Text, culture);

Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var results = NumberRecognizer.RecognizeNumber(message.Text, culture);
should also have SuppressExtendedTypes

var results = NumberRecognizer.RecognizeNumber(message.Text, culture, NumberOptions.SuppressExtendedTypes);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants