-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Recognizers-Text version from v1.1.3 to v1.2.6 #2448
Upgrade Recognizers-Text version from v1.1.3 to v1.2.6 #2448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discovered another spot requiring SuppressExtendedTypes
Discovered
botbuilder-dotnet/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/NumberPrompt.cs
Line 105 in 44d011b
var results = NumberRecognizer.RecognizeNumber(message.Text, culture); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
botbuilder-dotnet/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/NumberPrompt.cs
Line 105 in 44d011b
var results = NumberRecognizer.RecognizeNumber(message.Text, culture); |
var results = NumberRecognizer.RecognizeNumber(message.Text, culture, NumberOptions.SuppressExtendedTypes);
Description
This PR upgrades the version of Recognizers-Text from v1.1.3 to v1.2.6 (latest stable version).
Changes made
Microsoft.Recognizers.Text.Choice
andMicrosoft.Recognizers.Text.DateTime
onMicrosoft.Bot.Builder.Dialogs
tov.1.2.6
NumberOptions.SuppressExtendedTypes
to the NumberRecognizer inChoiceRecognizers
Testing