Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication: Change Semaphore to SemaphoreSlim, improve logging and error handling #2486

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Authentication: Change Semaphore to SemaphoreSlim, improve logging and error handling #2486

merged 2 commits into from
Sep 9, 2019

Conversation

carlosscastro
Copy link
Member

Ran performance analysis over load testing to verify performance is not affected by this change under load.

@coveralls
Copy link
Collaborator

coveralls commented Sep 9, 2019 •
edited

Pull Request Test Coverage Report for Build 78280

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.364%
Totals Coverage Status
Change from base Build 77817: 0.0%
Covered Lines: 3401
Relevant Lines: 4232
💛 - Coveralls

@fuselabs
Copy link
Collaborator

fuselabs commented Sep 9, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@carlosscastro carlosscastro marked this pull request as ready for review September 9, 2019 18:12
@fuselabs
Copy link
Collaborator

fuselabs commented Sep 9, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@cleemullins cleemullins merged commit b3f4b48 into master Sep 9, 2019
@cleemullins cleemullins deleted the ccastro/auth-semaphore-logging branch September 9, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlosscastro @coveralls @fuselabs @cleemullins