add Teams SDK and test scenarios #2517
Conversation
Pull Request Test Coverage Report for Build 79198
💛 - Coveralls |
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
| using Microsoft.Bot.Schema.Teams; | ||
| using Newtonsoft.Json.Linq; | ||
|
|
||
| namespace Microsoft.BotBuilderSamples |
There was a problem hiding this comment.
Should this be Microsoft.Bot.Builder.Teams
There was a problem hiding this comment.
nice catch! updated in the SDK code - but I'm having trouble with the Scenario.sln - perhaps because I created that in vs19 and I'm trying to fix it in vs17 on my laptop - anyhow SDK code should be good.
There was a problem hiding this comment.
I also had that issue... which is what this was about:
But i reverted it, thinking it might have been my env
…to set correct Type
…ageResponse sets type to "message"
Remove adaptive card .json files
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
[Teams] add TaskModule scenario to johtaylo/botbuilder-teams
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
add projects to Scenarios.sln
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
update TeamsActivityHandler SelectItem to pass JObject
…oft/botbuilder-dotnet into johtaylo/botbuilder-teams
* Implement OnTeamsAppBasedLinkQueryAsync OnTeamsAppBasedLinkQueryAsync takes AppBasedLinkQuery * Remove IHostingEnvironment (not needed)
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
|
@EricDahlvang @johnataylor @cleemullins Thank you very much for this PR. Also do you know if composeExtension/onquerySettingsUrl will be sent instead of composeExtension/querySettingUrl ?
|
|
Hi @VKAlwaysWin Thank you for this feedback! We certainly will add composeExtension/onCardButtonClicked. I'm sorry we missed that. Thank you for bringing this to our attention. I will look into the querySettingUrl question, and get back to you. Please do let us know if you find any other improvements we should address. |
|
@VKAlwaysWin we will certainly include the composeExtension/onCardButtonClicked event if we've missed it. Our process is to build a scenario out that triggers the feature and then we added the code to the ActivityHandler. Temporarily we added a solution to help with this, you can find that under test/Teams/Scenarios.sln. So please do take a look at that if you thing we have missed anything. interested. The other point about the "on" is just our naming convention, to aid discoverability we've prepended OnTeams to all the Teams specific methods. |
No description provided.