Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concat Attachments if exist in Prompt::AppendChoices #2520

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Concat Attachments if exist in Prompt::AppendChoices #2520

merged 1 commit into from
Sep 17, 2019

Conversation

xieofxie
Copy link
Contributor

Close #2102

  • concat Attachments if exist in Prompt::AppendChoices
    • if it is carousel AttachmentLayout, it will be weird..
  • add test ShouldSendPromptUsingAppendedHeroCard

Concat Attachments if exist in Prompt::AppendChoices
509e33f 
add test ShouldSendPromptUsingAppendedHeroCard
@xieofxie xieofxie mentioned this pull request Sep 16, 2019
Closed
@cleemullins
Copy link
Contributor

@EricDahlvang Can you take a quick look at this before it's merged in?

EricDahlvang
EricDahlvang approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @xieofxie !

This was referenced Sep 16, 2019
Closed
Closed
@cleemullins cleemullins merged commit bcd22ea into microsoft:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@EricDahlvang EricDahlvang EricDahlvang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppendChoices in Prompt should keep original attachments
3 participants
@xieofxie @cleemullins @EricDahlvang