Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional unit test #2530

Merged
merged 1 commit into from
Sep 17, 2019
Merged

additional unit test #2530

merged 1 commit into from
Sep 17, 2019

Conversation

johnataylor
Copy link
Member

No description provided.

@johnataylor
Copy link
Member Author

@VKAlwaysWin thanks for the heads up - fixed the event name in this PR and we are working with the Teams Team on finding about more about the additional event you mentioned.

@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2019

Pull Request Test Coverage Report for Build 79382

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 77.842%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Teams/TeamsActivityHandler.cs 34 55.29%
Totals Coverage Status
Change from base Build 79359: -1.1%
Covered Lines: 4546
Relevant Lines: 5840

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@johnataylor johnataylor merged commit 82f59b8 into master Sep 17, 2019
@johnataylor johnataylor deleted the johtaylo/more-unit-tests branch September 17, 2019 22:36
@VKAlwaysWin
Copy link

VKAlwaysWin commented Sep 19, 2019

@johnataylor thank you very much.

Regarding composeExtension/onCardButtonClicked it was also mentioned here: MicrosoftDocs/msteams-docs#947 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants