Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AdaptiveCard dependency from Teams packages #2532

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Remove AdaptiveCard dependency from Teams packages #2532

merged 1 commit into from
Sep 17, 2019

Conversation

EricDahlvang
Copy link
Member

Also update CardActions and TaskModule bots.

@cleemullins cleemullins merged commit 5565651 into master Sep 17, 2019
@cleemullins cleemullins deleted the eric/lessAdaptiveCardsDependency branch September 17, 2019 23:22
@EricDahlvang EricDahlvang mentioned this pull request Sep 18, 2019
Closed
14 tasks
@coveralls
Copy link
Collaborator

coveralls commented Sep 18, 2019 •
edited

Pull Request Test Coverage Report for Build 79403

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 78.554%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs 1 56.41%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs 2 50.0%
Totals Coverage Status
Change from base Build 79396: 0.5%
Covered Lines: 84230
Relevant Lines: 107225
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EricDahlvang @coveralls @cleemullins