Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a project to show how mentions works #2535

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Conversation

Virtual-Josh
Copy link
Contributor

This is a sample project to show how mentions works within Teams. This also removes the code about mentions from the Roster project.

Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are excluding the .zip of the manifest. We might need ro remove it from other projects too?

tests/Teams/Mentions/appsettings.json Outdated Show resolved Hide resolved
Copy link
Member

@johnataylor johnataylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we don't need to check in the manifest zip files. we should probably go through and get rid of them all. but not a big deal right now - we have checked them in all over the place.

tests/Teams/Mentions/Startup.cs Outdated Show resolved Hide resolved
tests/Teams/Mentions/ActivityLog.cs Outdated Show resolved Hide resolved
tests/Teams/Mentions/Bots/MentionsBot.cs Outdated Show resolved Hide resolved
tests/Teams/Mentions/appsettings.json Outdated Show resolved Hide resolved
@johnataylor
Copy link
Member

i think it's nice to have this sample - at least it's going to help the docs.

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@coveralls
Copy link
Collaborator

coveralls commented Sep 18, 2019

Pull Request Test Coverage Report for Build 79600

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.26%

Totals Coverage Status
Change from base Build 79583: 0.0%
Covered Lines: 3599
Relevant Lines: 4429

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@johnataylor johnataylor dismissed EricDahlvang’s stale review September 18, 2019 18:37

looks like Josh has resolved this

@johnataylor johnataylor merged commit ac7cb1a into master Sep 18, 2019
@johnataylor johnataylor deleted the josh/mentionProject branch September 18, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 October 31, 2019 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants