-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a project to show how mentions works #2535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are excluding the .zip of the manifest. We might need ro remove it from other projects too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we don't need to check in the manifest zip files. we should probably go through and get rid of them all. but not a big deal right now - we have checked them in all over the place.
i think it's nice to have this sample - at least it's going to help the docs. |
…ncellation token, updating manifest.json
a84ba05
to
7a46b00
Compare
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
Pull Request Test Coverage Report for Build 79600
💛 - Coveralls |
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
looks like Josh has resolved this
This is a sample project to show how mentions works within Teams. This also removes the code about mentions from the Roster project.