Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Teams Scenario] Adding Proactive Solution #2557

Merged
merged 4 commits into from
Sep 20, 2019
Merged

[Teams Scenario] Adding Proactive Solution #2557

merged 4 commits into from
Sep 20, 2019

Conversation

Virtual-Josh
Copy link
Contributor

Adding a proactive messaging solution

@Virtual-Josh Virtual-Josh added 4.6 October 31, 2019 Release teams labels Sep 19, 2019
@coveralls
Copy link
Collaborator

coveralls commented Sep 19, 2019 •
edited

Pull Request Test Coverage Report for Build 79963

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.23%
Totals Coverage Status
Change from base Build 79839: 0.0%
Covered Lines: 3605
Relevant Lines: 4438
💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

stevengum
stevengum approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor cleanup

tests/Teams/ProactiveMessages/Bots/ProactiveMessageBot.cs Outdated Show resolved Hide resolved
tests/Teams/ProactiveMessages/Bots/ProactiveMessageBot.cs Outdated Show resolved Hide resolved
tests/Teams/ProactiveMessages/ProactiveMessages.csproj Show resolved Hide resolved
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@Virtual-Josh Virtual-Josh merged commit e4c379d into master Sep 20, 2019
@Virtual-Josh Virtual-Josh deleted the josh/proactiveMessages branch September 20, 2019 16:58
@stevengum stevengum changed the title Adding Proactive Solution [Teams Scenario] Adding Proactive Solution Sep 20, 2019
@stevengum stevengum mentioned this pull request Sep 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@cleemullins cleemullins Awaiting requested review from cleemullins

@johnataylor johnataylor Awaiting requested review from johnataylor

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

Assignees
No one assigned
Labels
4.6 October 31, 2019 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Virtual-Josh @coveralls @fuselabs @stevengum