Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionBasedMessagingExtension Scenario #2588

Merged
merged 4 commits into from
Sep 25, 2019
Merged

ActionBasedMessagingExtension Scenario #2588

merged 4 commits into from
Sep 25, 2019

Conversation

stevengum
Copy link
Member

For comparison to #2579

@stevengum stevengum added teams 4.6 October 31, 2019 Release labels Sep 23, 2019
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action.MessagePayload.From.User.DisplayName <- this is interesting!

I like how this demonstrates multiple commands.

@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2019

Pull Request Test Coverage Report for Build 80534

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.007%) to 79.928%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/HttpHelper.cs 2 93.94%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkHttpAdapter.cs 3 75.0%
/libraries/Microsoft.Bot.Builder.Teams/TeamsActivityHandler.cs 10 75.68%
Totals Coverage Status
Change from base Build 80222: 0.007%
Covered Lines: 4906
Relevant Lines: 6138

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@stevengum stevengum merged commit 7a23812 into master Sep 25, 2019
@stevengum stevengum deleted the stgum/action branch September 25, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 October 31, 2019 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants