Add <DefineConstants>SIGNASSEMBLY</DefineConstants> to .csproj file. #2590
Conversation
| @@ -19,6 +19,10 @@ | |||
| <DocumentationFile>bin\$(Configuration)\netstandard2.0\Microsoft.Bot.Builder.Adapters.Webex.xml</DocumentationFile> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(SignAssembly)'=='true' "> | |||
There was a problem hiding this comment.
Wouldn't it be good to define this constant in Directory.Build.props (at the root of the solution) so we can take advantage of this setting across the board?
There was a problem hiding this comment.
That could be done, in which case it should go in as:
true
true
If that is OK with you, I am willing.
There was a problem hiding this comment.
Let's do that so it is easier to add internal tests in the future.
Thanks
There was a problem hiding this comment.
OK, I added it. You approve?
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
1 similar comment
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
…nly in Directory.Build.props.
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1 |
No description provided.