Sync read of request body throws on .netcore 3.0 #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, to avoid .netcore3 sync IO restrictions.
|
|
|
How can I trigger CI? |
|
This comment here should trigger the CI build. |
|
@gabog, when you get time could you look into this? Everything here looks reasonable, but there may be more to do. |
|
@cleemullins I do not see the CI triggered |
|
@cleemullins or @gabog any updates? |
|
@gabog or @garypretty could you review this when you get a moment? |
garypretty
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
LGTM - for reference, details of the changes to disable synchronous read / write of body can be found in the Microsoft docs for migrating from .NET Core 2.2 to 3.
|
Gary has built / tested this, and run a full CI build against the code. This is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serializing http request and response bodies async from memorystream, to avoid .netcore3 sync IO restrictions.
This PR does not address similar issues in Twilio, WebEx and ApplicationInsights projects.
An alternative option would be to use System.Text.Json with superior performance (memory and CPU), but serialization settings would need to be regression tested + it would introduce a new dependency to this package.