Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Teams] Messaging Extension Preview Send/Edit #2637

Merged
merged 2 commits into from
Oct 1, 2019
Merged

[Teams] Messaging Extension Preview Send/Edit #2637

merged 2 commits into from
Oct 1, 2019

Conversation

EricDahlvang
Copy link
Member

Add OnTeamsMessagingExtensionBotMessagePreviewSendAsync
and OnTeamsMessagingExtensionBotMessagePreviewEditAsync
to ActionBasedMessagingExtensionFetchTaskBot

Fixes: #2619

Add OnTeamsMessagingExtensionBotMessagePreviewSendAsync and OnTeamsMe…
ca671b5 
…ssagingExtensionBotMessagePreviewEditAsync to ActionBasedMessagingExtensionFetchTaskBot
@coveralls
Copy link
Collaborator

coveralls commented Oct 1, 2019 •
edited

Pull Request Test Coverage Report for Build 81310

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 536 unchanged lines in 78 files lost coverage.
  • Overall coverage decreased (-0.3%) to 78.24%
Files with Coverage Reduction New Missed Lines %
/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Twilio/TwilioAdapter.cs 1 85.71%
/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs 1 71.43%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs 1 95.45%
/libraries/Microsoft.Bot.Builder/BotStateSet.cs 1 85.0%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/PromptValidatorContext.cs 1 82.35%
/libraries/Microsoft.Bot.Builder.Dialogs/WaterfallStepContext.cs 1 86.96%
/libraries/Microsoft.Bot.Builder/Inspection/InspectionSession.cs 1 76.47%
/libraries/Microsoft.Bot.Builder/ShowTypingMiddleware.cs 1 94.55%
/libraries/Microsoft.Bot.Builder/Teams/TeamsTurnContextExtensions.cs 1 85.71%
/libraries/Microsoft.Bot.Builder.Testing/XUnit/TestDataObject.cs 1 82.35%
Totals Coverage Status
Change from base Build 81231: -0.3%
Covered Lines: 11125
Relevant Lines: 14219
💛 - Coveralls

@fuselabs
Copy link
Collaborator

fuselabs commented Oct 1, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

johnataylor
johnataylor approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@johnataylor johnataylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments on naming around the helper functions?

tests/Teams/ActionBasedMessagingExtension-FetchTask/AdaptiveCardHelper.cs Outdated Show resolved Hide resolved
tests/Teams/ActionBasedMessagingExtension-FetchTask/AdaptiveCardHelper.cs Outdated Show resolved Hide resolved
tests/Teams/ActionBasedMessagingExtension-FetchTask/AdaptiveCardHelper.cs Outdated Show resolved Hide resolved
@EricDahlvang EricDahlvang added 4.6 October 31, 2019 Release teams labels Oct 1, 2019
@fuselabs
Copy link
Collaborator

fuselabs commented Oct 1, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@EricDahlvang EricDahlvang merged commit 40ecdb7 into master Oct 1, 2019
@EricDahlvang EricDahlvang deleted the eric/messagingExtensionsPreviewEditSend branch October 1, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

@stevengum stevengum Awaiting requested review from stevengum

@Virtual-Josh Virtual-Josh Awaiting requested review from Virtual-Josh

Assignees
No one assigned
Labels
4.6 October 31, 2019 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEAMS] build scenario for bot preview
4 participants
@EricDahlvang @coveralls @fuselabs @johnataylor