Add Facebook Adapter migration #2640

ceciliaavila · 2019-10-01T20:21:46Z

Description

This PR has the migration to .Net of the FacebookAdapter Package from the BotKit repo.

Also, we added a TestBot for testing the current implementation.

Details

We have migrated the following classes:

FacebookAdapter
FacebookAdapterOptions
FacebookClientWrapper

And added some helper classes:
FacebookHelper
FacebookMessage
Message

Remove unreferenced methods, change type initializations to var, add IDisposable handling, remove this keyword

coveralls · 2019-10-01T20:34:01Z

Pull Request Test Coverage Report for Build 84908

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.5%) to 77.505%

Totals
Change from base Build 84883:	1.5%
Covered Lines:	6002
Relevant Lines:	7744

💛 - Coveralls

fuselabs · 2019-10-01T20:35:00Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

* Add webhook validation * Fix message's signature validation

fuselabs · 2019-10-02T21:03:58Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

GetAPIAsync method removed from adapter code

fuselabs · 2019-10-08T19:24:31Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-10-08T19:25:30Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

* Add tests for standby messages and adapter * Used Verify statement to test methods call

Add remaining wrapper tests Fix hash in failing test

…icrosoft/BotBuilder-dotnet into add/facebook-adapter-migration

fuselabs · 2019-10-11T21:18:11Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookAdapter.cs

libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookHelper.cs

libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookMessage.cs

libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookEvents/FacebookEntry.cs

...ies/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookEvents/FacebookResponseEvent.cs

garypretty

Updated comments following discussions with the team. Please make the changes asap as I would like to get this merged today if possible. TODO comments can be left for the preview package providing the work to remove them can take place over the next couple of weeks ahead of the next release.

Change attachments processing not to throw exceptions on more than one Change methods not to return null but rather an exception on null input Adapter unit tests Changed backslashes to forward slashes (Unix pipeline build problem)

Change README.MD settings variable names Change minor polishing

garypretty · 2019-10-22T15:06:24Z

@matiasroldan6 Thanks for the changes. Please resolve conflicts for this branch and then I can approve.

fuselabs · 2019-10-22T15:32:54Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

garypretty · 2019-10-22T19:02:45Z

@matiasroldan6 @ceciliaavila Just Facebook remaining now. Will approve / merge once merge conflicts have been resolved.

fuselabs · 2019-10-22T20:21:33Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

matiasroldan6 and others added 6 commits September 30, 2019 13:21

Add base project with previous work

1266e35

[Facebook Adapter] Initial corrections

8c3fb09

Remove unreferenced methods, change type initializations to var, add IDisposable handling, remove this keyword

[Slack Adapter] Add Helper class

4f2bbda

[Facebook Adapter] Migrate methods to FacebookClientWrapper

73da059

Add Facebook TestBot project

5c628ef

[Facebook Adapter] Fix CallAPIAsync requests payload

08de7cd

ceciliaavila added 2 commits October 2, 2019 10:17

Small refactors

52b2100

Add webhook validation

ed007c3

* Add webhook validation * Fix message's signature validation

matiasroldan6 and others added 11 commits October 3, 2019 11:12

Add Facebook structure classes

e9f85e8

Add FacebookBotUser and corrections

f299280

Fix TimeStamp in FacebookMessage class

093e591

Add FacebookPostback class

a676860

Fix GetAppSecretProof method

16eed78

Add Json Properties

96ce9dd

Fix serialization

3085518

Fix serialization

19839d6

Remove dynamic from GetApiAsync method

618ffe7

Add Attachments functionality

bb10b86

[Facebook Adapter] Add most of adapters tests

5d1e18c

GetAPIAsync method removed from adapter code

LCarbonellRod and others added 6 commits October 9, 2019 15:46

Add FacebookWrapperTests class

833c641

Add Helper tests

2d8fdd9

[Facebook Adapter] Add tests for standby messages and adapter

966ee57

* Add tests for standby messages and adapter * Used Verify statement to test methods call

Add wrapper tests

c2fb00f

Merge branch 'master' into add/facebook-adapter-migration

2a473b7

[Facebook Adapter] Add remaining wrapper tests

83f2380

Add remaining wrapper tests Fix hash in failing test

ceciliaavila and others added 5 commits October 10, 2019 17:46

Add support for Template Messages

c409e77

Merge branch 'add/facebook-adapter-migration' of https://github.com/M…

d858e46

…icrosoft/BotBuilder-dotnet into add/facebook-adapter-migration

Fix failing unit tests

d341986

Merge branch 'master' into add/facebook-adapter-migration

89d7a96

Exclude POCO classes from coverage

ebd1694

cleemullins assigned garypretty Oct 17, 2019

garypretty requested changes Oct 18, 2019

View reviewed changes

LCarbonellRod and others added 2 commits October 18, 2019 14:37

Add README file

548487e

PR requested changes

b47cf51

garypretty requested changes Oct 22, 2019

View reviewed changes

matiasroldan6 added 3 commits October 22, 2019 10:18

Applied attachments feedback

ff20b75

Change attachments processing not to throw exceptions on more than one Change methods not to return null but rather an exception on null input Adapter unit tests Changed backslashes to forward slashes (Unix pipeline build problem)

Change README.MD

4c166bc

Change README.MD settings variable names Change minor polishing

Merge branch 'master' into add/facebook-adapter-migration

974b832

matiasroldan6 and others added 3 commits October 22, 2019 13:37

Fix backslashes - Remove class from CC

5c36cf4

Change hash in test for VerifySignature

67551b1

Ignore rule CA1308

84646ff

matiasroldan6 and others added 3 commits October 22, 2019 16:23

Merge branch 'master' into add/facebook-adapter-migration

136cee6

Fix hash for failing test

9124d8f

Fix CodeCoverage.runsettings bad merge

2507ce6

ceciliaavila requested a review from garypretty October 22, 2019 20:22

garypretty approved these changes Oct 22, 2019

View reviewed changes

garypretty merged commit a066813 into master Oct 22, 2019

cleemullins deleted the add/facebook-adapter-migration branch October 24, 2019 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Facebook Adapter migration #2640

Add Facebook Adapter migration #2640

ceciliaavila commented Oct 1, 2019 •

edited

coveralls commented Oct 1, 2019 •

edited

fuselabs commented Oct 1, 2019

fuselabs commented Oct 2, 2019

fuselabs commented Oct 8, 2019

fuselabs commented Oct 8, 2019

fuselabs commented Oct 11, 2019

garypretty left a comment •

edited

garypretty commented Oct 22, 2019

fuselabs commented Oct 22, 2019

garypretty commented Oct 22, 2019

fuselabs commented Oct 22, 2019

Add Facebook Adapter migration #2640

Add Facebook Adapter migration #2640

Conversation

ceciliaavila commented Oct 1, 2019 • edited

Description

Details

coveralls commented Oct 1, 2019 • edited

Pull Request Test Coverage Report for Build 84908

💛 - Coveralls

fuselabs commented Oct 1, 2019

fuselabs commented Oct 2, 2019

fuselabs commented Oct 8, 2019

fuselabs commented Oct 8, 2019

fuselabs commented Oct 11, 2019

garypretty left a comment • edited

Choose a reason for hiding this comment

garypretty commented Oct 22, 2019

fuselabs commented Oct 22, 2019

garypretty commented Oct 22, 2019

fuselabs commented Oct 22, 2019

ceciliaavila commented Oct 1, 2019 •

edited

coveralls commented Oct 1, 2019 •

edited

garypretty left a comment •

edited