Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Teams] Add ComposeMessagingExtensionAuthBot #2646

Merged
merged 2 commits into from
Oct 2, 2019
Merged

[Teams] Add ComposeMessagingExtensionAuthBot #2646

merged 2 commits into from
Oct 2, 2019

Conversation

EricDahlvang
Copy link
Member

Fixes: #2633

@coveralls
Copy link
Collaborator

coveralls commented Oct 2, 2019 •
edited

Pull Request Test Coverage Report for Build 81467

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 78.329%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs 1 56.41%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs 2 50.0%
Totals Coverage Status
Change from base Build 81370: 0.3%
Covered Lines: 4135
Relevant Lines: 5279
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 81395

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 78.329%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs 1 56.41%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs 2 50.0%
Totals Coverage Status
Change from base Build 81370: 0.3%
Covered Lines: 4135
Relevant Lines: 5279
💛 - Coveralls

@fuselabs
Copy link
Collaborator

fuselabs commented Oct 2, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

Virtual-Josh
Virtual-Josh approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@Virtual-Josh Virtual-Josh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clearab clearab mentioned this pull request Oct 2, 2019
Open
@fuselabs
Copy link
Collaborator

fuselabs commented Oct 2, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

@EricDahlvang EricDahlvang merged commit aad49ad into master Oct 2, 2019
@EricDahlvang EricDahlvang mentioned this pull request Oct 2, 2019
Closed
@EricDahlvang EricDahlvang deleted the eric/addComposeMessageExtensionAuthBot branch October 2, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

@Virtual-Josh Virtual-Josh Virtual-Josh approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEAMS] OAuth via extension scenario
5 participants
@EricDahlvang @coveralls @fuselabs @johnataylor @Virtual-Josh