Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.OAuthInput.schema #2687

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Update Microsoft.OAuthInput.schema #2687

merged 3 commits into from
Oct 10, 2019

Conversation

luhan2017
Copy link
Contributor

@luhan2017 luhan2017 commented Oct 9, 2019 •
edited

Remove the reference to InputDialog base.
#2673

@vishwacsena
Copy link
Contributor

@luhan2017 - we need to re-target this to master branch.

@luhan2017
Copy link
Contributor Author

@luhan2017 - we need to re-target this to master branch.

OK, all the input dialogs didn't have a required section, we may need to add them all.

@vishwacsena
Copy link
Contributor

OK, all the input dialogs didn't have a required section, we may need to add them all.

Yes. Let's do a required properties for all inputs for 4.7.

vishwacsena
vishwacsena reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@vishwacsena vishwacsena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomlm can you please review?

@luhan2017 luhan2017 changed the base branch from 4.Future to master October 9, 2019 23:47
@vishwacsena vishwacsena requested a review from tomlm October 9, 2019 23:47
@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2019 •
edited

Pull Request Test Coverage Report for Build 82575

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.4%) to 77.171%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs 1 76.24%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs 1 57.23%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs 2 50.0%
/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs 2 86.09%
Totals Coverage Status
Change from base Build 82572: -1.4%
Covered Lines: 6514
Relevant Lines: 8441
💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

tomlm
tomlm approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit 0dac9ea into master Oct 10, 2019
@tomlm tomlm deleted the luhan/OAuthSchemaFix branch October 10, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

@vishwacsena vishwacsena vishwacsena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@luhan2017 @vishwacsena @coveralls @fuselabs @tomlm