Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more structured-lg test #2694

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Add more structured-lg test #2694

merged 1 commit into from
Oct 11, 2019

Conversation

Danieladu
Copy link
Collaborator

Add more structured-lg test

tomlm
tomlm approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm changed the base branch from 4.Future to master October 10, 2019 19:35
@Danieladu Danieladu closed this Oct 11, 2019
@Danieladu Danieladu deleted the hond/structured-lg-test branch October 11, 2019 05:49
@Danieladu Danieladu restored the hond/structured-lg-test branch October 11, 2019 05:51
@Danieladu Danieladu reopened this Oct 11, 2019
@coveralls
Copy link
Collaborator

coveralls commented Oct 11, 2019 •
edited

Pull Request Test Coverage Report for Build 82866

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.3%) to 77.283%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs 1 76.24%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs 1 57.23%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs 2 50.0%
/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs 2 86.09%
Totals Coverage Status
Change from base Build 82853: -1.3%
Covered Lines: 7583
Relevant Lines: 9812
💛 - Coveralls

@Danieladu Danieladu added the LG label Oct 11, 2019
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@Danieladu Danieladu merged commit 25c9bde into master Oct 11, 2019
@Danieladu Danieladu deleted the hond/structured-lg-test branch October 11, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

@feich-ms feich-ms feich-ms approved these changes

@cosmicshuai cosmicshuai Awaiting requested review from cosmicshuai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Danieladu @coveralls @fuselabs @tomlm @feich-ms @cleemullins