Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Async, Cleanup all warnings, nuget package definitions iconurl etc. #2698

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Oct 10, 2019

Zero warnings

@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2019

Pull Request Test Coverage Report for Build 82721

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 127 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.4%) to 76.801%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/DialogManager.cs 21 70.0%
/libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs 106 40.53%
Totals Coverage Status
Change from base Build 82619: -1.4%
Covered Lines: 7131
Relevant Lines: 9285

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants