Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate LuisV3 => Luis assembly in LuisV3 namespace #2702

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Oct 10, 2019

We had 2 assemblies, Luis and LuisV3, this delta moves LuisV3 into the LUIS assembly but in it's own namespace.

@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2019

Pull Request Test Coverage Report for Build 82791

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 77.265%

Totals Coverage Status
Change from base Build 82781: -1.0%
Covered Lines: 7565
Relevant Lines: 9791

💛 - Coveralls

@carlosscastro
Copy link
Member

I wish we didn't use version numbers in assemblies. Given that this already exists and we are just moving it around, approving.

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@tomlm tomlm merged commit 54556e4 into master Oct 10, 2019
@tomlm tomlm deleted the tomlm/mergeLuis branch October 10, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants