Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Teams] Rename some Teams classes and fields #2703

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

EricDahlvang
Copy link
Member

Rename MessagingExtensionResponse.ComposeExtension to MessagingExtensionResponse.MessagingExtension and MessagingExtensionSuggestedAction to MessagingExtensionOpenUrlAction

…ionResponse.MessagingExtension and MessagingExtensionSuggestedAction to MessagingExtensionOpenUrlAction
@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2019

Pull Request Test Coverage Report for Build 82807

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.571%

Totals Coverage Status
Change from base Build 82800: 0.0%
Covered Lines: 5390
Relevant Lines: 6860

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@tomlm
Copy link
Contributor

tomlm commented Oct 14, 2019

I'm good with this, but would like @johnataylor to sign off.

@johnataylor johnataylor merged commit 3eb9fc5 into master Oct 15, 2019
@johnataylor johnataylor deleted the eric/renameTeamsClasses branch October 15, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants