Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventValue initialization from ctor #2705

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Fix EventValue initialization from ctor #2705

merged 2 commits into from
Oct 15, 2019

Conversation

Ky7m
Copy link
Contributor

@Ky7m Ky7m commented Oct 10, 2019

No description provided.

@tomlm
Copy link
Contributor

tomlm commented Oct 11, 2019

    public EmitEvent(string eventName = null, object eventValue = null, bool bubble = true, [CallerFilePath] string callerPath = "", [CallerLineNumber] int callerLine = 0)

this should be a string, eventValue is intented to be a property path to memory that is evaluated when the EmitEvent is executed #Resolved


Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/EmitEvent.cs:19 in efe2522. [](commit_id = efe2522, deletion_comment = False)

Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@tomlm
Copy link
Contributor

tomlm commented Oct 11, 2019

    private const string EventValuePropertyValue = "eventValue";

I think we should remove this.


Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/EmitEvent.cs:16 in efe2522. [](commit_id = efe2522, deletion_comment = False)

@Ky7m
Copy link
Contributor Author

Ky7m commented Oct 11, 2019

thank you @tomlm for comments. Fixed now.

@Ky7m Ky7m changed the title Fix EventValue initialization from ctor and from dialog context state Fix EventValue initialization from ctor Oct 11, 2019
@Ky7m Ky7m requested a review from tomlm October 11, 2019 06:54
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants